Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: limit sidechain consensus addr update interval #318

Merged
merged 4 commits into from
Feb 1, 2023

Conversation

owen-reorg
Copy link
Contributor

@owen-reorg owen-reorg commented Jan 9, 2023

Description

Sidechain consensus address modification is introduced in BEP159, which enables the sidechain validators to change their consensus address.

The proposer choice in BSC is related to the consensus address. There is a chance that a validator may improve the possibility to be chosen by changing the consensus address. So the update interval is limited to be changed once a month.

TODOs

  • add integration test
  • add hardfork

@owen-reorg owen-reorg marked this pull request as draft January 9, 2023 14:48
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2023

Codecov Report

Merging #318 (e4fa4af) into develop (5b60d2c) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #318      +/-   ##
===========================================
- Coverage    46.47%   46.42%   -0.06%     
===========================================
  Files          242      242              
  Lines        23195    23221      +26     
===========================================
  Hits         10781    10781              
- Misses       11767    11793      +26     
  Partials       647      647              

@unclezoro unclezoro marked this pull request as ready for review February 1, 2023 01:56
@unclezoro unclezoro changed the title limit sidechain consensus addr update interval feat: limit sidechain consensus addr update interval Feb 1, 2023
@unclezoro unclezoro added the r4r label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants