Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R] update dependency #152

Merged
merged 2 commits into from
Jun 19, 2019
Merged

[R4R] update dependency #152

merged 2 commits into from
Jun 19, 2019

Conversation

yutianwu
Copy link
Contributor

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yutianwu yutianwu requested review from ackratos and rickyyangz June 19, 2019 11:14
HaoyangLiu
HaoyangLiu reviewed Jun 19, 2019
View reviewed changes
Gopkg.lock Outdated
@@ -445,16 +445,15 @@
version = "v0.14.1"

[[projects]]
digest = "1:1d88f1320e234cdf1627b9025a5b565bceb597795e76db163af5e298cc715cae"
digest = "1:1ac12d8dc0930588ad4082b0c186c4a602a17dee5e74869c0237b212ed4e5fee"
name = "github.com/tendermint/iavl"
packages = ["."]
pruneopts = "UT"
revision = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the revision is empty?

@yutianwu yutianwu merged commit eef6714 into develop Jun 19, 2019
@forcodedancing forcodedancing deleted the update_dep branch May 18, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoyangLiu HaoyangLiu HaoyangLiu approved these changes

@ackratos ackratos Awaiting requested review from ackratos

@rickyyangz rickyyangz Awaiting requested review from rickyyangz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yutianwu @HaoyangLiu