[R4R] fix state_sync #150
Merged
[R4R] fix state_sync #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ackratos
force-pushed
the
statesync_upgrade_fix
branch
from
fc532fd to
c49ad65
Compare
yutianwu
reviewed
Jun 19, 2019
store/statesync_helper.go
Outdated
| names := make([]string, 0, len(kvStores)) | ||
| nameToKey := make(map[string]sdk.StoreKey, len(kvStores)) | ||
| for key, store := range cms.GetCommitKVStores() { | ||
| for key, store := range helper.commitMS.GetCommitKVStores() { |
There was a problem hiding this comment.
why not use kvStores above
ackratos
added a commit
to bnb-chain/node
that referenced
this pull request
Jun 19, 2019
HaoyangLiu
reviewed
Jun 19, 2019
store/statesync_helper.go
Outdated
| names := make([]string, 0, len(kvStores)) | ||
| nameToKey := make(map[string]sdk.StoreKey, len(kvStores)) | ||
| for key, store := range cms.GetCommitKVStores() { | ||
| for key, store := range helper.commitMS.GetCommitKVStores() { |
There was a problem hiding this comment.
How about replacing helper.commitMS.GetCommitKVStores() with kvStores? Here you call helper.commitMS.GetCommitKVStores() twice.
ackratos
added a commit
to bnb-chain/node
that referenced
this pull request
Jun 19, 2019
4 tasks
HaoyangLiu
approved these changes
Jun 19, 2019
yutianwu
approved these changes
Jun 19, 2019
ackratos
force-pushed
the
statesync_upgrade_fix
branch
from
aa91c18 to
c530429
Compare
ackratos
added a commit
to bnb-chain/node
that referenced
this pull request
Jun 19, 2019
ackratos
force-pushed
the
statesync_upgrade_fix
branch
from
c530429 to
99f7fee
Compare
forcodedancing
pushed a commit
to bnb-chain/node
that referenced
this pull request
May 19, 2022
forcodedancing
pushed a commit
to bnb-chain/node
that referenced
this pull request
May 19, 2022
forcodedancing
pushed a commit
to bnb-chain/node
that referenced
this pull request
May 19, 2022
forcodedancing
pushed a commit
to bnb-chain/node
that referenced
this pull request
May 19, 2022
forcodedancing
pushed a commit
to bnb-chain/node
that referenced
this pull request
May 19, 2022
forcodedancing
pushed a commit
to bnb-chain/node
that referenced
this pull request
May 19, 2022
forcodedancing
pushed a commit
to bnb-chain/node
that referenced
this pull request
May 19, 2022
forcodedancing
pushed a commit
to bnb-chain/node
that referenced
this pull request
May 19, 2022
forcodedancing
pushed a commit
to bnb-chain/node
that referenced
this pull request
May 19, 2022
forcodedancing
pushed a commit
to bnb-chain/node
that referenced
this pull request
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes newly added store might broken statesync.
This fix makes state sync helper no longer cache mounted stores (as they may dynamically change according to upgrade) and load needed stores according to upgrade height.
cosmos build and unit test can pass
node manually test (state sync before and after upgrade) can pass