Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R] update dependency #137

Merged
merged 2 commits into from
May 23, 2019
Merged

[R4R] update dependency #137

merged 2 commits into from
May 23, 2019

Conversation

yutianwu
Copy link
Contributor

Update version of github.com/golang/protobuf to stay the same with tendermint.

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yutianwu yutianwu force-pushed the update_dependency branch from b7110c5 to 43237c6 Compare May 23, 2019 02:42
@yutianwu yutianwu merged commit 4847726 into develop May 23, 2019
@forcodedancing forcodedancing deleted the update_dependency branch May 18, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickyyangz rickyyangz rickyyangz approved these changes

@HaoyangLiu HaoyangLiu HaoyangLiu approved these changes

@unclezoro unclezoro Awaiting requested review from unclezoro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yutianwu @HaoyangLiu @rickyyangz