Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R] #581 pass tx source into msg handler via context #133

Merged
merged 1 commit into from
May 27, 2019
Merged

[R4R] #581 pass tx source into msg handler via context #133

merged 1 commit into from
May 27, 2019

Conversation

ackratos
Copy link
Contributor

@ackratos ackratos commented May 20, 2019 •
edited
Loading

Node PR: bnb-chain/node#582
build & test are passed

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@ackratos ackratos added the enhancement New feature or request label May 20, 2019
@ackratos ackratos self-assigned this May 20, 2019
@ackratos ackratos mentioned this pull request May 20, 2019
Merged
4 tasks
@ackratos ackratos changed the title #581 pass tx source into msg handler via context [R4R] #581 pass tx source into msg handler via context May 20, 2019
@ackratos ackratos merged commit eb85398 into master May 27, 2019
This was referenced May 27, 2019
Closed
Merged
@forcodedancing forcodedancing deleted the issue581 branch May 18, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yutianwu yutianwu yutianwu approved these changes

@HaoyangLiu HaoyangLiu HaoyangLiu approved these changes

@darren-liu darren-liu Awaiting requested review from darren-liu

@rickyyangz rickyyangz Awaiting requested review from rickyyangz

Assignees

@ackratos ackratos

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ackratos @HaoyangLiu @yutianwu