Merge pull request #330 from bnb-chain/develop

release: prepare for the release v0.26.0

CHANGELOG.md

@@ -1,5 +1,8 @@
 # Changelog
 
+##v0.26.0
+* [sec] [\#328](https://github.com/bnb-chain/bnc-cosmos-sdk/pull/328) sec: implement security enhancements (#328)
+
 ##v0.25.9
 
 * [sdk] [\#300](https://github.com/bnb-chain/bnc-cosmos-sdk/pull/300) feats: add ics23 proof support

store/statesync_helper.go

@@ -181,6 +181,10 @@ func (helper *StateSyncHelper) WriteRecoveryChunk(hash abci.SHA256Sum, chunk *ab
 	if chunk != nil {
 		numOfNodes := len(chunk.Nodes)
 		nodes := make([]*iavl.Node, 0, numOfNodes)
+
+		if numOfNodes == 0 {
+			return fmt.Errorf("length of nodes is 0")
+		}
 
 		helper.logger.Info("start write recovery chunk", "isComplete", isComplete, "hash", fmt.Sprintf("%x", hash), "startIdx", chunk.StartIdx, "numOfNodes", numOfNodes, "chunkCompletion", chunk.Completeness)
 
@@ -200,6 +204,7 @@ func (helper *StateSyncHelper) WriteRecoveryChunk(hash abci.SHA256Sum, chunk *ab
 					return err
 				}
 			}
+
 			nodeIdx := chunk.StartIdx + int64(numOfNodes-1)
 			helper.incompleteChunks[nodeIdx] = append(helper.incompleteChunks[nodeIdx],
 				incompleteChunkItem{
@@ -277,6 +282,10 @@ func (helper *StateSyncHelper) saveIncompleteChunks() error {
 		// sort and check chunkItems are valid
 		sort.Sort(&chunkItemSorter{chunkItems})
 
+		if len(chunkItems) == 0 {
+			return fmt.Errorf("length of chunks is 0")
+		}
+
 		expectedNodeParts := chunkItems[len(chunkItems)-1].chunkIdx - chunkItems[0].chunkIdx + 1
 		if expectedNodeParts != len(chunkItems) {
 			return fmt.Errorf("node parts are not complete, should be %d, but have %d, nodeIdx: %d", expectedNodeParts, len(chunkItems), nodeIdx)

types/store.go

@@ -287,7 +287,7 @@ func (key *KVStoreKey) String() string {
 // range query for all []byte with a certain prefix
 // Deals with last byte of prefix being FF without overflowing
 func PrefixEndBytes(prefix []byte) []byte {
-	if prefix == nil {
+	if len(prefix) == 0 {
 		return nil
 	}