-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tested, multi-lingual user guide #677
Conversation
So are we trying to convert the entire project over to kotlin at this point? |
@cdancy No, this is just to document that you can use the plugin from a build script that leverages the Kotlin DSL. The plugin implementation will likely always stay in Groovy. Hope this makes things more clear. |
It's just a big change and trying to get a grep of what's in it. Looks entirely doc related and if I didn't know any better I'd say you were attempting to write a book about this plugin :) |
@cdancy No book planned really. ;-) I do it for two reasons:
You are right. This PR is only about documentation. We will want to change the implementation though to allow Kotlin DSL users to use the reactive streams properly. At least I couldn't find a way to make it work yet. You might want to generate the documentation for this branch just to see the effects of the change. |
Sounds good. @bmuschko is the "closures not working" a known issue we can work around with Kotlin? I've only been looking into the language very recently so I'm not sure if there is something analogous we can do. |
Actually it appears there is a solution: https://github.com/gradle/kotlin-dsl/blob/master/doc/getting-started/Closures.md |
@cdancy Thanks for this pointer. I have been using this before but without any parameters. I will give it a shot. The example you posted shows how to deal with it. |
@cdancy Had a look at it again. The |
@bmuschko found this project this morning and appears to have a fair amount of helper functions we may be able to use with kotlin/gradle interop. https://github.com/nebula-plugins/nebula-gradle-interop |
@cdancy Thanks for the pointer. It won't be necessary. Currently, working on some internal changes that will leave the existing usage from the Groovy DSL intact while at the same time demonstrating the use from the Kotlin DSL for the reactive streams. Everything else is already useable from the Kotlin DSL. |
The testing of the source code revealed:
Closure
type)