MINOR: only log error when rack aware assignment is enabled (apache#1…

…4415) Reviewers: Lucas Brutschy <[email protected]>, Matthias J. Sax <[email protected]>
bmscomp · Sep 29, 2023 · e71f6eb · e71f6eb
1 parent 03259f6
commit e71f6eb
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/...n/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java b/...n/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java
@@ -212,8 +212,11 @@ private boolean validateClientRack(final Map<UUID, Map<String, Optional<String>>
             KeyValue<String, String> previousRackInfo = null;
             for (final Map.Entry<String, Optional<String>> rackEntry : entry.getValue().entrySet()) {
                 if (!rackEntry.getValue().isPresent()) {
-                    log.error(String.format("RackId doesn't exist for process %s and consumer %s",
-                        processId, rackEntry.getKey()));
+                    if (!StreamsConfig.RACK_AWARE_ASSIGNMENT_STRATEGY_NONE.equals(assignmentConfigs.rackAwareAssignmentStrategy)) {
+                        log.error(
+                            String.format("RackId doesn't exist for process %s and consumer %s",
+                                processId, rackEntry.getKey()));
+                    }
                     return false;
                 }
                 if (previousRackInfo == null) {
@@ -232,7 +235,9 @@ private boolean validateClientRack(final Map<UUID, Map<String, Optional<String>>
                 }
             }
             if (previousRackInfo == null) {
-                log.error(String.format("RackId doesn't exist for process %s", processId));
+                if (!StreamsConfig.RACK_AWARE_ASSIGNMENT_STRATEGY_NONE.equals(assignmentConfigs.rackAwareAssignmentStrategy)) {
+                    log.error(String.format("RackId doesn't exist for process %s", processId));
+                }
                 return false;
             }
             racksForProcess.put(entry.getKey(), previousRackInfo.value);