updates based on PR comments

bmoscon · Jan 24, 2024 · 12994cf · 12994cf
1 parent f039f69
commit 12994cf
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,6 +1,6 @@
 ## Changelog
 
-### 2.5.0
+### 2.4.2
  * Update: transitioned from Coinbase Pro (retired) to Coinbase Advanced Trade
 
 ### 2.4.1

diff --git a/cryptofeed/exchanges/coinbase.py b/cryptofeed/exchanges/coinbase.py
@@ -88,14 +88,6 @@ def __init__(self, callbacks=None, **kwargs):
     def __reset(self):
         self._l2_book = {}
 
-    async def _ticker(self, msg: dict, timestamp: float):
-        # TODO: The ticker endpoint payload has been updated and no longer includes best ask and bid.
-        #  Do we want to:
-        #  1. get rid of that callback
-        #  2. implement ticker based on l2 book sub
-        #  3. implement a new ticker callback (will be different from other exchanges)
-        raise NotImplementedError
-
     async def _trade_update(self, msg: dict, timestamp: float):
         '''
         {