Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove typeRoots and adjust types for Jest support #574

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Dec 6, 2024

Hi there! I was looking through the repository and noticed something that could be improved, so I’ve created this PR. Since this is my first PR, please feel free to point out any misunderstandings or issues 🙇‍♂️.

  • Fixed the error Cannot find name 'test' by correctly configuring the Jest types.
  • Removed the typeRoots configuration as the types directory did not exist.

@ddzz ddzz requested a review from bmish December 6, 2024 13:37
Copy link
Owner

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks right.

I made a similar fix in another similar repository recently: bmish/check-dependency-version-consistency#706

@bmish bmish added the internal label Dec 6, 2024
@bmish bmish merged commit 0ad8110 into bmish:main Dec 6, 2024
2 checks passed
@y-hsgw y-hsgw deleted the update-tsconfig branch December 6, 2024 14:18
@bmish bmish changed the title Fix: Remove typeRoots and adjust types for Jest support Remove typeRoots and adjust types for Jest support Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants