-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: drop node.js 14.x and 16.x testing #536
Conversation
We should remove 14 and 16 from the |
This comment was marked as outdated.
This comment was marked as outdated.
@bmish Can you review this PR and its related issues when you have a moment? |
I was originally planning to delay modifying engines until the repo is compatible with ESLint v9, then change the prerequisites of |
@bmish is MIA so I'll approve and merge this. We should add Node 20.x to the matrix in another PR. Thanks for all your work in this repo! |
Thank you! This makes it cleaner for the follow-on PRs. I'm happy to work on this knowing you are there to review and merge. 🙂 I don't think we need @bmish at this time. He may still be traveling. |
Agreed, however the workflow is not yet compatible with Node.js >= 20 (otherwise I would have already added it). I am however planning to look at this. |
14.x
and16.x
testing in CI #535Issue
14.x
and16.x
reached Node.js End-of-life more than one year ago and so are unsupported by Node.js.^18.18.0
. This rules out Node.js14.x
and16.x
.Change
14.x
and16.x
from thenode-version
matrix in .github/workflows/ci.yml.