Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update eslint to 8.57.1 #530

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Oct 17, 2024

Issue

ESLint is configured in package.json with eslint@^8.24.0 and locked to [email protected], released Jan 2023, in package-lock.json.

A minimum version of [email protected] is required to support flat config files, which requires ESLint peerDependencies ^8.56.0.

Change

  • Update to latest eslint@8 ([email protected]), released Sep 16, 2024.
  • Add rule 'unicorn/expiring-todo-comments': 'off' to avoid linting failures.

Verification

On Ubuntu 24.04.1 LTS, Node.js 18.20.4

git clean -xfd
npm ci
npm run lint
npm test

Ignore warnings from npm ci:

npm warn deprecated @npmcli/[email protected]: This functionality has been moved to @npmcli/fs
npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/[email protected]: Use @eslint/object-schema instead
npm warn deprecated [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options.

Confirm no errors and no uncommitted changes.

add rule unicorn/expiring-todo-comments: off
@MikeMcC399 MikeMcC399 marked this pull request as ready for review October 17, 2024 14:10
@MikeMcC399 MikeMcC399 mentioned this pull request Oct 17, 2024
@MikeMcC399

This comment was marked as resolved.

@ddzz
Copy link
Collaborator

ddzz commented Oct 21, 2024

Workflow approved, merging once CI passes.

@ddzz ddzz merged commit 6520b48 into bmish:main Oct 21, 2024
6 checks passed
@MikeMcC399 MikeMcC399 deleted the update/eslint branch October 21, 2024 13:26
@MikeMcC399
Copy link
Contributor Author

@ddzz

Thank you! Good to see you're available to review and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants