-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add emoji for type-checked
config
#519
Comments
I’m confused; what does “type-checked” indicate? |
It's just one possible name that plugins might use for configs containing type-aware rules, which would usually have Note that plugins don't need to use this name or config, as the idea is just to provide emojis for a variety of common or possible config names. |
that seems like a really weird name since it appears to describe the config itself rather than the code it’s linting - nobody should care if the plugin code is type-checked or not. |
Hmm perhaps the name is misleading since it's not that the lint rule itself is type-checked but rather that the lint rule takes into account type information while operating on the user's code, so it does have a user-facing impact. Type-checked aka type-aware rules can be smarter as a result. Either way, I'm not really making a judgment here about whether this is an advisable config name to use, but the name is inspired from typescript-eslint which has been using this convention of |
|
|
Oh shoot I missed this till now - The problem is, we just did a set of config renames like So... as much as I prefer "aware", I'm not sure that it can be more than just a nice terminology alias for a while in typescript-eslint itself 😞. Which makes it hard to recommend other configs use it. |
I'm thinking we can add our current TypeScript-related emoji of ⌨️ to the config name
type-checked
going along with some of the existing TypeScript/type-related config names we have. We wouldn't use ☑️ for this since it's not necessarily related to the recommended config.Follow-up to:
Related discussion:
CC: @JoshuaKGoldberg
The text was updated successfully, but these errors were encountered: