You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't love that this doesn't have its own emoji 😞 is there some standard practice that can be done?
Yes I would just give it a different color checkmark like ☑️ in .eslint-doc-generatorrc.js.
Would adding recommended-type-checked: ☑️ to the list of built-in rule config emojis make be reasonable? I don't know of configs other than typescript-eslint that use that (pending eslint-community/eslint-plugin-eslint-plugin#433), but it strikes me as a reasonable preset.
My original idea behind using ☑️ for it is that this black/white checkmark is a variation of the green checkmark ✅ used for recommended, the same way that recommended-type-checked is a variation/extension of the recommended config. There's also ✔️ but that is a bit less consistent with the styling.
There's also ⌨️ which could make sense as we're using it for other TypeScript-related configs, but it doesn't have the benefit that ☑️ does of implying a relation to the recommended config.
Coming over from eslint-community/eslint-plugin-eslint-plugin#433 (comment):
Would adding
recommended-type-checked: ☑️
to the list of built-in rule config emojis make be reasonable? I don't know of configs other than typescript-eslint that use that (pending eslint-community/eslint-plugin-eslint-plugin#433), but it strikes me as a reasonable preset.eslint-doc-generator/lib/emojis.ts
Lines 11 to 17 in e669f76
The text was updated successfully, but these errors were encountered: