Skip to content

Commit

Permalink
build: generate binlog in out directories
Browse files Browse the repository at this point in the history
Directories link `Release\` will be created as a junction to
`out\Release` when build completes. When binlog was written to
`Release\` before the junction is created, the build will fail for
unable to create junction when directory `Release\` already exists.

PR-URL: nodejs#53325
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
  • Loading branch information
legendecas authored and bmeck committed Jun 22, 2024
1 parent ed69e2f commit e03022e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion vcbuild.bat
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ if /i "%1"=="cctest" set cctest=1&goto arg-ok
if /i "%1"=="openssl-no-asm" set openssl_no_asm=1&goto arg-ok
if /i "%1"=="no-shared-roheap" set no_shared_roheap=1&goto arg-ok
if /i "%1"=="doc" set doc=1&goto arg-ok
if /i "%1"=="binlog" set extra_msbuild_args=/binaryLogger:%config%\node.binlog&goto arg-ok
if /i "%1"=="binlog" set extra_msbuild_args=/binaryLogger:out\%config%\node.binlog&goto arg-ok

echo Error: invalid command line option `%1`.
exit /b 1
Expand Down

0 comments on commit e03022e

Please sign in to comment.