Skip to content

Commit

Permalink
tbdev turndown: No longer allow usage of tensorboard dev upload. (t…
Browse files Browse the repository at this point in the history
…ensorflow#6638)

In this step of the TensorBoard.dev turndown, we remove the ability to
upload via the `tensorboard dev upload` command.

Instead, when a user invokes `tensorboard dev upload`, we print the
following message, which is similar to the message we currently return
in the server info from TensorBoard.dev backends:

```
****************************************************************
****************************************************************
****************************************************************

Uploading TensorBoard logs to https://tensorboard.dev/ is no longer
supported.

TensorBoard.dev is shutting down.

Please export your experiments by Dec 31, 2023.

See the FAQ at https://tensorboard.dev.

****************************************************************
****************************************************************
****************************************************************
```

We also remove a bunch of upload-specific code.

Testing:
I tested the changes by trying some version of the following commands:
`bazel run tensorboard -- dev auth revoke`
`bazel run tensorboard -- dev upload`
`bazel run tensorboard -- dev list`
`bazel run tensorboard -- dev update-metadata`
`bazel run tensorboard -- dev delete`
`bazel run tensorboard -- dev export`
  • Loading branch information
bmd3k committed Nov 2, 2023
1 parent e16abe5 commit b63c5b0
Show file tree
Hide file tree
Showing 9 changed files with 43 additions and 3,457 deletions.
48 changes: 1 addition & 47 deletions tensorboard/uploader/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ py_library(
visibility = ["//tensorboard:internal"],
deps = [
":auth",
":dry_run_stubs",
":exporter",
":flags_parser",
":formatters",
Expand All @@ -79,7 +78,6 @@ py_library(
"//tensorboard:expect_absl_logging_installed",
"//tensorboard:expect_grpc_installed",
"//tensorboard:program",
"//tensorboard/compat:tensorflow",
"//tensorboard/plugins:base_plugin",
"//tensorboard/uploader/proto:protos_all_py_pb2_grpc",
],
Expand All @@ -90,7 +88,6 @@ py_test(
srcs = ["uploader_subcommand_test.py"],
srcs_version = "PY3",
deps = [
":dry_run_stubs",
":server_info",
":uploader",
":uploader_subcommand",
Expand All @@ -104,21 +101,11 @@ py_library(
srcs = ["uploader.py"],
srcs_version = "PY3",
deps = [
":logdir_loader",
":upload_tracker",
":util",
"//tensorboard:expect_grpc_installed",
"//tensorboard:expect_protobuf_installed",
"//tensorboard/backend:process_graph",
"//tensorboard/backend/event_processing:directory_loader",
"//tensorboard/backend/event_processing:event_file_loader",
"//tensorboard/backend/event_processing:io_wrapper",
"//tensorboard/compat/proto:protos_all_py_pb2",
"//tensorboard/plugins/graph:metadata",
"//tensorboard/uploader/proto:protos_all_py_pb2",
"//tensorboard/util:grpc_util",
"//tensorboard/util:tb_logging",
"//tensorboard/util:tensor_util",
],
)

Expand All @@ -133,28 +120,15 @@ py_test(
srcs = ["uploader_test.py"],
srcs_version = "PY3",
deps = [
":dry_run_stubs",
":server_info",
":test_util",
":upload_tracker",
":uploader",
":util",
"//tensorboard:data_compat",
"//tensorboard:dataclass_compat",
"//tensorboard:expect_grpc_installed",
"//tensorboard:expect_grpc_testing_installed",
"//tensorboard:expect_protobuf_installed",
"//tensorboard:expect_tensorflow_installed",
"//tensorboard/compat:no_tensorflow",
"//tensorboard/compat/proto:protos_all_py_pb2",
"//tensorboard/plugins/graph:metadata",
"//tensorboard/plugins/histogram:summary_v2",
"//tensorboard/plugins/scalar:metadata",
"//tensorboard/plugins/scalar:summary_v2",
"//tensorboard/summary:summary_v1",
"//tensorboard/uploader/proto:protos_all_py_pb2",
"//tensorboard/uploader/proto:protos_all_py_pb2_grpc",
"//tensorboard/util:test_util",
],
)

Expand All @@ -168,26 +142,6 @@ py_test(
],
)

py_library(
name = "dry_run_stubs",
srcs = ["dry_run_stubs.py"],
srcs_version = "PY3",
deps = [
"//tensorboard/uploader/proto:protos_all_py_pb2",
],
)

py_test(
name = "dry_run_stubs_test",
srcs = ["dry_run_stubs_test.py"],
srcs_version = "PY3",
deps = [
":dry_run_stubs",
"//tensorboard:test",
"//tensorboard/uploader/proto:protos_all_py_pb2",
],
)

py_library(
name = "auth",
srcs = ["auth.py"],
Expand Down Expand Up @@ -257,8 +211,8 @@ py_test(
name = "util_test",
srcs = ["util_test.py"],
deps = [
":test_util",
":util",
"//tensorboard:expect_grpc_installed",
"//tensorboard:expect_protobuf_installed",
"//tensorboard:test",
],
Expand Down
53 changes: 0 additions & 53 deletions tensorboard/uploader/dry_run_stubs.py

This file was deleted.

52 changes: 0 additions & 52 deletions tensorboard/uploader/dry_run_stubs_test.py

This file was deleted.

Loading

0 comments on commit b63c5b0

Please sign in to comment.