Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in documentation of resample function #116

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Fix error in documentation of resample function #116

merged 1 commit into from
Dec 16, 2022

Conversation

karpp
Copy link
Contributor

@karpp karpp commented Dec 16, 2022

Fix error stating default value of parameter "parallel" in resample function

Fix error stating default value of parameter "parallel" in resample function
Copy link
Contributor

@avalentino avalentino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmcfee
Copy link
Owner

bmcfee commented Dec 16, 2022

LGTM, thanks!

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2022

Codecov Report

Base: 75.22% // Head: 75.22% // No change to project coverage 👍

Coverage data is based on head (2b57cbf) compared to base (1e96fa7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   75.22%   75.22%           
=======================================
  Files           4        4           
  Lines         113      113           
=======================================
  Hits           85       85           
  Misses         28       28           
Flag Coverage Δ
unittests 75.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
resampy/core.py 70.31% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bmcfee
Copy link
Owner

bmcfee commented Dec 16, 2022

Codecov fail is unrelated - happy to merge.

@bmcfee bmcfee merged commit 1d1a08a into bmcfee:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants