Fix abs windows path without volume #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backslashes from calling filePath.FromSlash on windows were causing the pattern to be treated as standard when it shouldn't be. This in turn caused incorrect assertions to be made, failing the tests on windows.
In 1.1.5 Glob() on windows matched absolute patterns without volume specified with the current working dir's volume. This broke in 1.2.x due to the use of filepath.IsAbs() which returns false if the volume is not present. This was causing paths starting with / or \ on windows to be erroneously evaluated from the current directory.
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
=======================================
Coverage 79.81% 79.81%
=======================================
Files 1 1
Lines 327 327
=======================================
Hits 261 261
Misses 41 41
Partials 25 25
Continue to review full report at Codecov.
|
|
Hey @idoru! Thanks for the PR! Looks good to me; I'll merge and cut a new release now. Sorry for the delay; been a busy few days! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat patterns starting with path separators (notably without volume specifiers) on windows as absolute.
This fixes such patterns erroneously being evaluated in the current working dir.
Changes to tests: