fix issue 1823 #1825
Closed
fix issue 1823 #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… config file as per issue bmaltais#1823
|
Hello @hopl1t this look like a great pr but it is modifying kohya sd-scripts files I clone to my repo. May I suggest you create a copy of this PR directly on his repo? When he merge the change I will then get the update when I pull his code into my repo. |
|
Reopened at the scripts repo: kohya-ss/sd-scripts#1032 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a command line argument that allows users to specify the wandb session name of their run.
Without this feature session names are not indicative.
While it is possible to fetch logger kwargs from a configuration toml this is cumbersome when sessions names are created in run time, which is very often the case.