Adds 'R' to gensim.prepare #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Rather than just accepting 'R' though lets take '**kargs' and pass them along. That is more future proof and keeps the API consistent. |
bmabey
added a commit
that referenced
this pull request
Jun 16, 2015
|
yes, that is what we i should have done! |
paul-english
added a commit
to paul-english/pyLDAvis
that referenced
this pull request
Aug 5, 2015
* 'master' of https://github.com/bmabey/pyLDAvis: (84 commits) fixes other typo in gl notebook fix typo use the graphlab API for it's prepare, 3x+ speed improvement! updates notebook with models from LDAvis package replaces use of map with list comprehension to help with bmabey#8 pass kargs to prepare fn in gensim and graphlab helpers. Closes bmabey#6, bmabey#7. releases v1.2.0 adds link to the R vignette that explains the visualization prevents prepare from blowing up when used with a vocab smaller than R make the gensim extraction more explicit... trying to find bug in logic updates gensim adapter to get topic term dists directly /ht @cscorley fixes Makefile to run on osx releases v1.1.0 change how web assets are served from github.. using detatched branch fixes graphlab viz fixes bug in graphlab model prepare causing bogus visualizations! doc fixes fix pypi badge release v1.0.0 prep for v1.0.0 release ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes input top terms to be shown.