Fix assumption that gensim dictionary and corpus are built from same … #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set of documents The dictionary may span a larger set of documents than any particular corpus, and the ids aren't necessarily congrouos or in order. Iterating the keys of the term_freqs_dict solves this. Additionally I've simplified term_freqs.
|
It looks like this may require additional updates in _prepare.py |
|
@bmabey Is this validation strictly required for later computation? https://github.com/bmabey/pyLDAvis/blob/master/pyLDAvis/_prepare.py#L41-L42 |
bmabey
added a commit
that referenced
this pull request
Jul 24, 2015
Fix assumption that gensim dictionary and corpus are built from same …
|
@log0ymxm that check is needed because vectorized math is performed under that assumption. Can you replace the missing elements with zeros? |
|
Locally I've commented that check out, and I'm still able to prepare the data for visualization. |
|
You may be attributing counts to the wrong term. I'd have to walk through the code to be sure though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…set of documents
The dictionary may span a larger set of documents than any particular corpus, and the ids aren't necessarily congrouos or in order. Iterating the keys of the term_freqs_dict solves this. Additionally I've simplified term_freqs.