Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add masterData types from eCH-0108 #8

Merged
merged 1 commit into from
Dec 11, 2023
Merged

add masterData types from eCH-0108 #8

merged 1 commit into from
Dec 11, 2023

Conversation

lars-steffen
Copy link
Contributor

direct reference to masterDataTypes from eCH-0108 instead of rebuilding them manually

montanajava
montanajava reviewed Dec 7, 2023
View reviewed changes
Copy link
Contributor

@montanajava montanajava left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I support merging. I would welcome your input as to how we need to modify the UML diagram.

@lars-steffen lars-steffen merged commit 3745607 into main Dec 11, 2023
1 check failed
@AFoletti AFoletti mentioned this pull request Dec 11, 2023
Merged
@lars-steffen
Copy link
Contributor Author

lars-steffen commented Jan 22, 2024 •
edited
Loading

resolves also #2

@lars-steffen lars-steffen mentioned this pull request Jan 22, 2024
Closed
@lars-steffen lars-steffen deleted the ech-0108-masterDataTypes branch May 13, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montanajava montanajava montanajava left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lars-steffen @montanajava