Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IU, mol, m #17

Closed
wants to merge 1 commit into from
Closed

Add IU, mol, m #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 31 additions & 7 deletions src/eCH-0261-1-0.xsd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,12 +518,12 @@ Datum Version Autor
<xs:documentation xml:lang="en">gamma</xs:documentation>
</xs:annotation>
</xs:enumeration>
<xs:enumeration value="µS">
<xs:enumeration value="S">
<xs:annotation>
<xs:documentation xml:lang="de">Mikro-Siemens</xs:documentation>
<xs:documentation xml:lang="fr">micro siemens</xs:documentation>
<xs:documentation xml:lang="it">micro siemens</xs:documentation>
<xs:documentation xml:lang="en">micro siemens</xs:documentation>
<xs:documentation xml:lang="de">Siemens</xs:documentation>
<xs:documentation xml:lang="fr">siemens</xs:documentation>
<xs:documentation xml:lang="it">siemens</xs:documentation>
<xs:documentation xml:lang="en">siemens</xs:documentation>
</xs:annotation>
</xs:enumeration>
<xs:enumeration value="%">
Expand All @@ -544,7 +544,7 @@ Datum Version Autor
</xs:enumeration>
<xs:enumeration value="kg/pc">
<xs:annotation>
<xs:documentation xml:lang="de">KiloGramm/Stück</xs:documentation>
<xs:documentation xml:lang="de">Kilogramm/Stück</xs:documentation>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed with #14
I think this branch needs a rebase before merging

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hint

<xs:documentation xml:lang="fr">kilogramme/pièce</xs:documentation>
<xs:documentation xml:lang="it">kilogrammo/litro</xs:documentation>
<xs:documentation xml:lang="en">kilogram/litre</xs:documentation>
Expand All @@ -558,6 +558,14 @@ Datum Version Autor
<xs:documentation xml:lang="en">Not applicable. Not all values have an associated unit but some elements declare unit as required. Use this for those cases.</xs:documentation>
</xs:annotation>
</xs:enumeration>
<xs:enumeration value="m">
<xs:annotation>
<xs:documentation xml:lang="de">Meter</xs:documentation>
<xs:documentation xml:lang="fr">mètre</xs:documentation>
<xs:documentation xml:lang="it">metri</xs:documentation>
<xs:documentation xml:lang="en">metre</xs:documentation>
</xs:annotation>
</xs:enumeration>
<xs:enumeration value="m2">
<xs:annotation>
<xs:documentation xml:lang="de">Quadratmeter</xs:documentation>
Expand All @@ -574,7 +582,7 @@ Datum Version Autor
<xs:documentation xml:lang="en">gram/square metre</xs:documentation>
</xs:annotation>
</xs:enumeration>
<xs:enumeration value="l/m2">
<xs:enumeration value="m3/m2">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never saw this combination used anywhere in my life. Granted, it's not wrong per se and I understand the effort aimed at using basic units already defined in the standard, but I find this instance highly confusing.

Suggestion: keep l/m2

<xs:annotation>
<xs:documentation xml:lang="de">Liter/Quadratmeter</xs:documentation>
<xs:documentation xml:lang="fr">litre/mètres carrés</xs:documentation>
Expand All @@ -590,6 +598,22 @@ Datum Version Autor
<xs:documentation xml:lang="en">piece/square metre</xs:documentation>
</xs:annotation>
</xs:enumeration>
<xs:enumeration value="IU">
<xs:annotation>
<xs:documentation xml:lang="de">internationale Einheit</xs:documentation>
<xs:documentation xml:lang="fr">unité internationale</xs:documentation>
<xs:documentation xml:lang="it">unità internazionale</xs:documentation>
<xs:documentation xml:lang="en">international unit</xs:documentation>
</xs:annotation>
</xs:enumeration>
<xs:enumeration value="mol">
<xs:annotation>
<xs:documentation xml:lang="de">Mol</xs:documentation>
<xs:documentation xml:lang="fr">mole</xs:documentation>
<xs:documentation xml:lang="it">mole</xs:documentation>
<xs:documentation xml:lang="en">mole</xs:documentation>
</xs:annotation>
</xs:enumeration>
</xs:restriction>
</xs:simpleType>
<xs:complexType name="enumeratedItemType">
Expand Down
Loading