Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

personFunctionType restriction #11

Closed
AFoletti opened this issue Dec 11, 2023 · 2 comments
Closed

personFunctionType restriction #11

AFoletti opened this issue Dec 11, 2023 · 2 comments

Comments

@AFoletti
Copy link
Member

AFoletti commented Dec 11, 2023 •
edited
Loading

personFunction-Code in personFunctionType is an xs:token with xs:maxLength value="6"
Is it intended to leave this element open to more or less anything up to 6 characters?
By looking at the documentation (PDF page 28) I am under the impression that:

  1. we should limit this to digits
  2. Actually, we should limit this to 6 digits, since higher hierarchical levels do not always make much sense in the context of this list (example: 0100 Andere (digiFLUX) may be OK, but 0201 Agrarsektordaten probably is not OK since is not really a role a person can have).

Number 2 would however need a refactoring of the list...

eCH-0261/src/eCH-0261-1-0.xsd

Line 542 in 77843b9

<xs:maxLength value="6"/>

Open for discussion 😄
@AFoletti AFoletti mentioned this issue Jan 26, 2024
Closed
lars-steffen added a commit that referenced this issue Jan 26, 2024
@lars-steffen
Update eCH-0261-1-0.xsd
b6cf472 
Add measureType and veracityType. Fix issues #11, #15, #20, #21
This was referenced Jan 26, 2024
Merged
Merged
lars-steffen added a commit that referenced this issue Jan 26, 2024
@lars-steffen
Merge pull request #23 from blw-ofag-ufag/improvements/v1/consistency…
32467d4 
…-with-spec

really fixing #11 by restricting the function code for persons to digits (not characters)
@lars-steffen
Copy link
Contributor

it was decided to leave the number of digits open (1 - 50)

@lars-steffen
Copy link
Contributor

fixed with #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AFoletti @lars-steffen