-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial version of pre-commit hooks #1
Conversation
fa35b75
to
c35f2d7
Compare
c35f2d7
to
7f849e8
Compare
85d4abd
to
998b69b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is being adapted from the internal check_commit.py
it is worth bearing in mind that this hook is currently only implementing the checkpatch
part of that script - the python function check_commit_message()
isn't part of it (probably something I cut out). It therefore needs to be considered if this hook needs to be expanded to also do those checks, or if another hook could do those, or if they aren't wanted for this.
Also, I appreciate that in reviewing this that I am in effect requesting changes to code that you didn't write yourself, and in some cases that I wrote, but what I gave you wasn't complete and we have also migrated Python versions since then.
Well, the per-commit checks are too specific to BWT, so, IMHO, we should drop that for now, and as a first cut stick with checkpatch + spellchecks (codespell). And also, we can just use |
360b447
to
b624d18
Compare
daadc5e
to
261f1b8
Compare
4e194bb
to
6c98bf1
Compare
b7e8b6d
to
8e2223f
Compare
754b214
to
f51ab10
Compare
f51ab10
to
44bc1bb
Compare
This has standard checks that are used in BW org across repositories. For now checkpatch is only added. Signed-off-by: Chaitanya Tata <[email protected]>
The actions does: * Run pre-commit hook * Run python unit tests Signed-off-by: Chaitanya Tata <[email protected]>
44bc1bb
to
9ca13da
Compare
This has standard checks that are used in BW org across repositories.