Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved support for borsh serialization #259

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Improved support for borsh serialization #259

merged 2 commits into from
Mar 7, 2024

Conversation

honzasp
Copy link
Contributor

@honzasp honzasp commented Jan 18, 2024 •
edited by bluss
Loading

Builds on #253 with the following improvements:

  • Do not allocate when deserializing ArrayString
  • Serialize length as u32, not as u64, to be consistent with serialization of [T] and str
  • Add tests

Closes #253

Fuuzetsu and others added 2 commits December 7, 2023 13:14
@Fuuzetsu
Optional support for borsh serialization
0921527
@honzasp
Improve optional support for borsh serialization
ac4928e 
- Do not allocate when deserializing ArrayString
- Serialize length as u32, not as u64, to be consistent with
  serialization of [T] and str
- Add tests
@honzasp honzasp mentioned this pull request Jan 18, 2024
Closed
@bluss
Copy link
Owner

bluss commented Mar 7, 2024

borsh docs say lengths are u32, then so it is.

@bluss bluss merged commit ae6cfd3 into bluss:master Mar 7, 2024
@bluss
Copy link
Owner

bluss commented Mar 7, 2024

Thanks both of you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@honzasp @bluss @Fuuzetsu