-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
take and into_inner_unchecked functions #187
Conversation
I'm impartial to the |
IMO .take() should be reserved for something that takes self, i.e ".take() -> ArrayVec" just like how Option::take works. That way, it can be Would it make sense to write ".take() -> ArrayVec" here and let the user compose it themselves with .into_inner()? |
Not a terrible idea. I'll implement that |
Thanks, this makes sense to include once docs are written and PR description is updated. 🙂 |
I'll update the PR with docs and tests later today then :) |
Thanks! |
Adds two new functions
into_inner_unchecked
, unsafe and unchecked variant ofinto_inner
take
, which returns the ArrayVec while only borrowing, replacing the original with a new empty ArrayVec