Use const generics in ArrayVec #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mriise
reviewed
Dec 20, 2020
mriise
reviewed
Dec 20, 2020
bluss
changed the title
Just search/replace for syntax [T; N] -> T, N and it works.
With const generics we can't avoid the usize (or other type) length field.
|
CI passes on beta and nightly - will pass fully when Rust 1.51 is released this week. |
I am wondering if rust-lang/rust#76560 can help with the size regression introduced here in future version of |
|
Later PR updated the length to always be u32 (for a smaller size). I can't answer your question, maybe you know? 🙂 |
|
It seems so to me, but I am not terribly familiar with Rust constant generics. Will try push a pull request when it is stable! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use const generics for ArrayVec and ArrayString - now it can support arbitrary capacity/backing array.
Syntax changes like this:
ArrayVec<[T; CAP]>ArrayVec<T, CAP>ArrayString<[u8; CAP]>ArrayString<CAP>The
ArrayVec<T, const CAP: usize>for now always uses anusizefor its length, and so uses more space than the oldArrayVec<[T; CAP]>.Requires Rust 1.51 (March 2021)
In for example Vim one can use the following substitution to update syntax:
Fixes #125
Closes #100