Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes needed for VSCode webview extension #186
Changes needed for VSCode webview extension #186
Changes from 24 commits
2360563
68ce41b
3242f84
6e9770f
1e74549
d7463aa
dd1fd9f
4012451
4564968
e399311
d97d13e
585b6a5
4e5b6b3
2b9ff93
4ad0be1
c588396
17cb77f
b80f150
856d55f
404aa85
7ef7e4c
f676bf1
0488a35
9e5d250
400b212
4205b19
265c9b8
7ec91ae
8d99f8f
b398e6e
64156b9
8d693c0
84f9039
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extension relies on this being called to update its internal document and mark the document as "dirty" so that it can be saved.
I think I got all the places that this needs to be called...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can benefit from this documentIsDirty in the electron version to add an * to the window title after a file has been edited.
Can we perhaps refactor this so yarn in general knows when a document is dirty (when running in electron or vscode).
If not, thats fine :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually can you just rename this function from
this.updateVsCodeExtensionDocument
to
this.setYarnDocumentIsDirty
later on we can use it to handle the electron case
@daviddq do you think it would be a good idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, in the VSCode webview,
#app
was a shifted few pixels to the right which was causing issues like arrows not rendering in the right spot.Adding this gets it to the right spot, and doesn't seem to have any effect on the web app.