Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#210 - main page #237

Merged
merged 53 commits into from
May 9, 2024
Merged

#210 - main page #237

merged 53 commits into from
May 9, 2024

Conversation

AleksandraKozubal
Copy link
Member

@AleksandraKozubal AleksandraKozubal commented Apr 15, 2024

Created main page view, navigation and footer with some components, translation, animation and rwd.
image
image
I'd have to add way too many screenshots to show all of the changes.

It should close #210

resources/views/components/article-card.blade.php Outdated Show resolved Hide resolved
resources/views/components/badge.blade.php Outdated Show resolved Hide resolved
resources/views/components/bubble.blade.php Outdated Show resolved Hide resolved
resources/views/components/dashboard/menu-item.blade.php Outdated Show resolved Hide resolved
resources/views/components/dashboard/menu-item.blade.php Outdated Show resolved Hide resolved
resources/views/layout/dashboard.blade.php Outdated Show resolved Hide resolved
resources/views/layout/footer.blade.php Outdated Show resolved Hide resolved
resources/views/layout/navigation.blade.php Outdated Show resolved Hide resolved
resources/views/layout/navigation.blade.php Outdated Show resolved Hide resolved
resources/css/app.css Outdated Show resolved Hide resolved
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I compare design (I took url from issue) and main page coded in this pr and I see some differences. For example:

  1. Navigation:

Design:

image

Implementation:

image

  1. Section "Jak możemy Ci pomóc?"

Design:

image

Implementation:

image

  1. Case study - can we really show screen of this page? And when I'm on English version of the page, I see case study description in Polish.

  2. Tech stack

Design:

image

Implementation:

image

  1. Section "Nasze aktywności"

Design:

image

Implementation:

image

  1. Section "Kontakt"

Design:

image

Implementation:

image

I'm not a big fan of these animated icons. I think we should meet and talk about differences between design and implementation - what differences are okay and which not

lang/en/content.php Outdated Show resolved Hide resolved
lang/en/content.php Outdated Show resolved Hide resolved
lang/en/content.php Outdated Show resolved Hide resolved
lang/en/content.php Outdated Show resolved Hide resolved
lang/en/content.php Outdated Show resolved Hide resolved
lang/en/content.php Outdated Show resolved Hide resolved
lang/en/content.php Outdated Show resolved Hide resolved
lang/pl/content.php Show resolved Hide resolved
@EwelinaSkrzypacz
Copy link
Member

EwelinaSkrzypacz commented May 7, 2024

When I reload the page, I see for a while that css is not loaded (it happens when I run npm run dev, but on build npm run build this problem doesn't occur

simplescreenrecorder-2024-05-07_11.16.20.mp4

@AleksandraKozubal
Copy link
Member Author

For me, padding is too big..

Here too:

Both changed

@AleksandraKozubal
Copy link
Member Author

AleksandraKozubal commented May 8, 2024

I compare design (I took url from issue) and main page coded in this pr and I see some differences. For example:

1. Navigation:

Design:

Implementation:

2. Section "Jak możemy Ci pomóc?"

Design:

Implementation:

3. Case study - can we really show screen of this page? And when I'm on English version of the page, I see case study description in Polish.

4. Tech stack

Design:

Implementation:

5. Section "Nasze aktywności"

Design:

Implementation:

6. Section "Kontakt"

Design:

Implementation:

I'm not a big fan of these animated icons. I think we should meet and talk about differences between design and implementation - what differences are okay and which not

1,3,4,5,6 changed to similar as in project.

Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a base now it's okay.

kamilpiech97
kamilpiech97 previously approved these changes May 8, 2024
resources/views/home.blade.php Outdated Show resolved Hide resolved
resources/views/home.blade.php Outdated Show resolved Hide resolved
resources/views/home.blade.php Outdated Show resolved Hide resolved
resources/views/components/testimonial.blade.php Outdated Show resolved Hide resolved
resources/views/layout/navigation.blade.php Outdated Show resolved Hide resolved
resources/views/layout/footer.blade.php Outdated Show resolved Hide resolved
@AleksandraKozubal AleksandraKozubal merged commit 1a5f666 into main May 9, 2024
3 checks passed
@AleksandraKozubal AleksandraKozubal deleted the #210-main-page branch May 9, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main page
6 participants