-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#210 - main page #237
#210 - main page #237
Conversation
# Conflicts: # tests/TestCase.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I compare design (I took url from issue) and main page coded in this pr and I see some differences. For example:
- Navigation:
Design:
Implementation:
- Section "Jak możemy Ci pomóc?"
Design:
Implementation:
-
Case study - can we really show screen of this page? And when I'm on English version of the page, I see case study description in Polish.
-
Tech stack
Design:
Implementation:
- Section "Nasze aktywności"
Design:
Implementation:
- Section "Kontakt"
Design:
Implementation:
I'm not a big fan of these animated icons. I think we should meet and talk about differences between design and implementation - what differences are okay and which not
When I reload the page, I see for a while that css is not loaded (it happens when I run simplescreenrecorder-2024-05-07_11.16.20.mp4 |
Both changed |
1,3,4,5,6 changed to similar as in project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a base now it's okay.
acaf7bb
Created main page view, navigation and footer with some components, translation, animation and rwd.
I'd have to add way too many screenshots to show all of the changes.
It should close #210