Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#456 - user profile #464

Merged
merged 4 commits into from
Jul 15, 2024
Merged

#456 - user profile #464

merged 4 commits into from
Jul 15, 2024

Conversation

kamilpiech97
Copy link
Member

Should close #456.
Added user profile page with summary almost all data connected with him in app - year scope. Added links where we have user in indexes or places in app which we has thing connected with users.

Preview:
image

@kamilpiech97 kamilpiech97 requested a review from a team as a code owner July 12, 2024 08:28
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. In my opinion, button "Zobacz wszystkie" on the list with vacation request/overtime request should redirect user with right role to vacation requests list/overtime request list filtered by this user.
  2. I think I will center the text to the avatar

image

  1. When user has a lot of devices, the list is really long and it doesn't look nice. Maybe we should show like five devices and add button "Zobacz wszystkie" and this button will redirect user to list of devices filtered by user

screencapture-toby-blumilk-localhost-users-7-2024-07-12-12_24_07

# Conflicts:
#	resources/js/Pages/AssignedBenefits/AssignedBenefits.vue
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When user is inactive, I go to his profile and on vacation request list I click "Zobacz wszystkie" -> I see page with no vacation requests. I have disabled option that I can see blocked users. I don't know if this problem for us

@kamilpiech97
Copy link
Member Author

When user is inactive, I go to his profile and on vacation request list I click "Zobacz wszystkie" -> I see page with no vacation requests. I have disabled option that I can see blocked users. I don't know if this problem for us

I would stick with this behavior.

@kamilpiech97 kamilpiech97 merged commit a5d1773 into main Jul 15, 2024
3 checks passed
@kamilpiech97 kamilpiech97 deleted the #456-user-profile branch July 15, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show user profile
3 participants