Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#443 - employment, medical and ohs history #451

Merged
merged 6 commits into from
Jun 28, 2024

Conversation

kamilpiech97
Copy link
Member

Should close #443.
Added option for administrator to manage users employment, medical exams and ohs trainings history.
Added artisan toby:move-user-data-to-history command for migrate data about ohs training and medical exam into user history.
Added tests.

Preview:

Screencast.from.18-06-24.09.24.19.webm

@kamilpiech97 kamilpiech97 requested a review from a team as a code owner June 18, 2024 07:25
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Date format should be dd.mm.yyyy, we have now yyyy-mm-dd.

image

  1. Padding is too small - please look at other

image

Like here

image

  1. Please translate "type"

image

  1. We should add information that comment is optional.

  2. Can we make like automatic history? I mean, when user has changes date of for example medical exams, can we add automatically entry to history?

@kamilpiech97
Copy link
Member Author

  1. Date format should be dd.mm.yyyy, we have now yyyy-mm-dd.

image

  1. Padding is too small - please look at other

image

Like here

image

  1. Please translate "type"

image

  1. We should add information that comment is optional.
  2. Can we make like automatic history? I mean, when user has changes date of for example medical exams, can we add automatically entry to history?
  1. FIxed but in #444 - overtime application process #447, I added helper for that, I would use them here after merge.
  2. Added
  3. Added
  4. Added
  5. Removed that fields from user create/edit view after merge that PR, I should open PR with that User profile table cleaning #452

Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When I add information about employment form, but I don't fill date to, I see error:

image

Event if I fill date to, the error still occurs.

  1. Please look at dates in other places in application - we have dots between numbers, not dashes.

History:

image

Requests:

image

  1. Information about that comment is optional should look the same as in requests, like

image

Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. When I add history about ohv and I don't fill date to, I see error

image

  1. When I add information about employment, I can add employment form employment contract without date to, but in other cases I can't. Is it by purpose?

@kamilpiech97
Copy link
Member Author

  1. When I add history about ohv and I don't fill date to, I see error

image

  1. When I add information about employment, I can add employment form employment contract without date to, but in other cases I can't. Is it by purpose?
  1. fixed
  2. Yep, it's conditionally.

Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why I see this? I believe that was for debugging and now it should be removed ;)

image

EDIT:

Validation messages are not consistent

image

@kamilpiech97
Copy link
Member Author

Why I see this? I believe that was for debugging and now it should be removed ;)

image

EDIT:

Validation messages are not consistent

image

fixed :DDD

@kamilpiech97 kamilpiech97 merged commit e2d7ddd into main Jun 28, 2024
3 checks passed
@kamilpiech97 kamilpiech97 deleted the #443-employment-history branch June 28, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add employment history
3 participants