-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#443 - employment, medical and ohs history #451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Date format should be dd.mm.yyyy, we have now yyyy-mm-dd.
- Padding is too small - please look at other
Like here
- Please translate "type"
-
We should add information that comment is optional.
-
Can we make like automatic history? I mean, when user has changes date of for example medical exams, can we add automatically entry to history?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When I add information about employment form, but I don't fill date to, I see error:
Event if I fill date to, the error still occurs.
- Please look at dates in other places in application - we have dots between numbers, not dashes.
History:
Requests:
- Information about that comment is optional should look the same as in requests, like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should close #443.
Added option for administrator to manage users
employment
,medical exams
andohs trainings
history.Added artisan
toby:move-user-data-to-history
command for migrate data aboutohs training
andmedical exam
into user history.Added tests.
Preview:
Screencast.from.18-06-24.09.24.19.webm