-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- switch beta to Blumilk's docker registry #432
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blusia
previously approved these changes
May 8, 2024
kamilpiech97
previously approved these changes
May 9, 2024
krzysztofrewak
previously approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To discuss:
should we move old images from ghcr.io to regostry.blumilk.pl? should we store images in both registries? should we remove all images from ghcr.io when migration to registry.blumilk.pl will be done?
I think:
- there's no need to move old images
- I would store them only in new one
- we should remove images from ghcr
EwelinaSkrzypacz
previously approved these changes
May 13, 2024
mtracz
dismissed stale reviews from EwelinaSkrzypacz, krzysztofrewak, kamilpiech97, and Blusia
via
May 13, 2024 07:07
9960dd4
I just pushed manually |
mtracz
requested review from
krzysztofrewak,
kamilpiech97,
EwelinaSkrzypacz and
Blusia
May 13, 2024 07:09
krzysztofrewak
approved these changes
May 14, 2024
kamilpiech97
approved these changes
May 14, 2024
EwelinaSkrzypacz
approved these changes
May 14, 2024
Blusia
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
ghcr.io
registry toregistry.blumilk.pl
.New images will be stored in our internal docker registry (Harbor). Toby project is publicly accessible.
The image name will be:
registry.blumilk.pl/toby/toby:beta
registry.blumilk.pl/toby/toby:latest
registry.blumilk.pl/toby/toby:v1.2.3
(depends on releases/tags)To discuss: