Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#400 - fixed n+1 queries in app #407

Merged
merged 5 commits into from
Mar 20, 2024
Merged

#400 - fixed n+1 queries in app #407

merged 5 commits into from
Mar 20, 2024

Conversation

kamilpiech97
Copy link
Member

Should close #400.
Resolved n+1 queries for all test firstly, then I clicked through all the pages and options throughout the application and found some n+1 issues and fixed them.

@EwelinaSkrzypacz, u must click through all the pages again and test my changes.

@kamilpiech97 kamilpiech97 requested a review from a team as a code owner March 19, 2024 09:45
@krzysztofrewak
Copy link
Member

Does it solve #398 as well?

@kamilpiech97
Copy link
Member Author

Does it solve #398 as well?

I do not think so, I see that in telescope:
image

we will optimize dashboard in new one PR.

EwelinaSkrzypacz
EwelinaSkrzypacz reviewed Mar 19, 2024
View reviewed changes
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find more n+1 queries in the app.

But I noticed that we have a lot of duplicated queries (not only on dashboard #398) but for example on index request page

image

Maybe we can solve this in this task or in #398?

@kamilpiech97
Copy link
Member Author

I can't find more n+1 queries in the app.

But I noticed that we have a lot of duplicated queries (not only on dashboard #398) but for example on index request page

image

Maybe we can solve this in this task or in #398?

I think, we can fixed them in #398.

@kamilpiech97 kamilpiech97 merged commit c96aa4e into main Mar 20, 2024
2 checks passed
@kamilpiech97 kamilpiech97 deleted the #400-n+1-quries branch March 20, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwelinaSkrzypacz EwelinaSkrzypacz EwelinaSkrzypacz approved these changes

@krzysztofrewak krzysztofrewak krzysztofrewak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

resolve N+1 queries
3 participants
@kamilpiech97 @krzysztofrewak @EwelinaSkrzypacz