#282 - Slack notification with approval buttons #347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #282.
For now I made it in a simple way - use things that we already have in our codebase. In the future we should make it using Slack Block Kit and Laravel package
laravel/slack-notification-channel
- I've made an issue for that #348.For technical approver it looks like this:
For administrative approver it look like this:
When user clicks for example button "Rejected", but the request is already rejected, he will see information about this:
In Slack API on production we have to update two things:
www.your-url-here.com/api/slack
towww.your-url-here.com/api/slack/commands
www.your-url-here.com/api/slack/actions
.