Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#282 - Slack notification with approval buttons #347

Merged

Conversation

EwelinaSkrzypacz
Copy link
Member

@EwelinaSkrzypacz EwelinaSkrzypacz commented Sep 7, 2023

This should close #282.

For now I made it in a simple way - use things that we already have in our codebase. In the future we should make it using Slack Block Kit and Laravel package laravel/slack-notification-channel - I've made an issue for that #348.

For technical approver it looks like this:

image

For administrative approver it look like this:

image

When user clicks for example button "Rejected", but the request is already rejected, he will see information about this:

image

In Slack API on production we have to update two things:

  1. In Slash Command tab the URL is changed from www.your-url-here.com/api/slack to www.your-url-here.com/api/slack/commands
  2. In tab Interactivity & Shortcuts the option Interactivity must be enabled and request URL should be www.your-url-here.com/api/slack/actions.

@EwelinaSkrzypacz EwelinaSkrzypacz marked this pull request as ready for review September 8, 2023 09:23
@EwelinaSkrzypacz EwelinaSkrzypacz requested a review from a team as a code owner September 8, 2023 09:23
@EwelinaSkrzypacz EwelinaSkrzypacz temporarily deployed to beta September 26, 2023 11:18 — with GitHub Actions Inactive
@EwelinaSkrzypacz EwelinaSkrzypacz merged commit 9b5a9ad into main Oct 2, 2023
3 checks passed
@EwelinaSkrzypacz EwelinaSkrzypacz deleted the #282-slack-notification-with-approval-buttons branch October 2, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack notification with approval buttons
3 participants