Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clean-up with inactive user #457

Closed
EwelinaSkrzypacz opened this issue Jul 3, 2024 · 0 comments · Fixed by #461
Closed

Make clean-up with inactive user #457

EwelinaSkrzypacz opened this issue Jul 3, 2024 · 0 comments · Fixed by #461

Comments

@EwelinaSkrzypacz
Copy link
Member

EwelinaSkrzypacz commented Jul 3, 2024

So, we have some little inconsistency with inactive employees.
For example:

  • on calendar view I don't see inactive user
  • but on vacation requests list I can see his vacation requests (but on users filter inactive users are not shown)
  • on vacation limits page I also see inactive user limit

So, after speaking a bit with Kamila, we think that we should by default hide all information about inactive users, but we can make some checkbox for example "Show inactive users vacation requests" and on vacation requests page we can see also inactive user requests, but records have gray background or something.

And we should change toast text, when admin click on user and click option "Zablokuj". Now we have "Usunięto użytkownika", but this is not entirely true, because all his information is in database. We can change it to "Dezaktywowano użytkownika" or "Zablokowano użytkownika".

kamilpiech97 added a commit that referenced this issue Jul 8, 2024
…zable and stuff for filtering them on indexes
kamilpiech97 added a commit that referenced this issue Jul 8, 2024
kamilpiech97 added a commit that referenced this issue Jul 8, 2024
kamilpiech97 added a commit that referenced this issue Jul 11, 2024
kamilpiech97 added a commit that referenced this issue Jul 12, 2024
kamilpiech97 added a commit that referenced this issue Jul 12, 2024
…457-inactive-user-cleanup

# Conflicts:
#	app/Http/Controllers/ResumeController.php
kamilpiech97 added a commit that referenced this issue Jul 12, 2024
kamilpiech97 added a commit that referenced this issue Jul 12, 2024
* #457 - feat: added checkbox for trashed users on vacations index

* #457 - feat: added some colors for blocked users to make them recognizable and stuff for filtering them on indexes

* #457 - fix: cleaning

* #457 - fix: cleaning 2

* #457 - fix: added permission to displaying inactive users on index views

* #457 - fix: ended adjustment connected with new permission for inactive users

* #457 - fix: code review fixes applied

* #457 - fix: code review fixes

* Update app/Http/Controllers/ResumeController.php

Co-authored-by: Krzysztof Rewak <[email protected]>

* #457 - fix: code review fixes

* #457 - fix: fix

---------

Co-authored-by: Krzysztof Rewak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant