Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor deprecated Rule contract #335

Closed
krzysztofrewak opened this issue Aug 18, 2023 · 0 comments · Fixed by #365
Closed

Refactor deprecated Rule contract #335

krzysztofrewak opened this issue Aug 18, 2023 · 0 comments · Fixed by #365
Assignees
@EwelinaSkrzypacz
Labels
backend backend feature php Pull requests that update Php code

Comments

@krzysztofrewak
Copy link
Member

Looks like Illuminate\Contracts\Validation\Rule is deprecated since... Laravel 5.6. It's still used in two files:

  • Toby\Infrastructure\Slack\Rules\SlackUserExistsRule
  • Toby\Infrastructure\Slack\Rules\YearPeriodExists

I would like to replace it with Illuminate\Contracts\Validation\ValidationRule, but it works slightly different, so some refactor will be needed.
@krzysztofrewak krzysztofrewak added backend backend feature php Pull requests that update Php code labels Aug 18, 2023
@EwelinaSkrzypacz EwelinaSkrzypacz self-assigned this Oct 12, 2023
EwelinaSkrzypacz added a commit that referenced this issue Oct 12, 2023
@EwelinaSkrzypacz
#335 - wip
9f04874
EwelinaSkrzypacz added a commit that referenced this issue Oct 13, 2023
@EwelinaSkrzypacz
#335 - wip
4f1269b
@EwelinaSkrzypacz EwelinaSkrzypacz mentioned this issue Oct 13, 2023
Merged
EwelinaSkrzypacz added a commit that referenced this issue Oct 20, 2023
@EwelinaSkrzypacz
#335 - refactor deprecated rule contract (#365)
8e3e751 
* #335 - wip

* #335 - wip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EwelinaSkrzypacz EwelinaSkrzypacz

Labels
backend backend feature php Pull requests that update Php code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#335 - refactor deprecated rule contract blumilksoftware/toby
2 participants
@krzysztofrewak @EwelinaSkrzypacz