Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify error handling for timed out signals when connecting. #97

Merged
merged 3 commits into from
Feb 16, 2024

Commits on Feb 14, 2024

  1. Modify error handling for timed out signals when connecting.

    This commit puts responsibility on anything with a .connect method
    to raise its own ConnectionTimeoutError, to be then picked up by
    the DeviceCollector, or not. This simplifies the complex error
    handling requiring timeouts to be handled at the asyncio level and
    passed up the called via (now redefined) NotConnected exceptions.
    rosesyrett authored and evalott100 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    dd3d5ca View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Improved propogation of errors

    Connection timeouts now result in a logging.debug, all other exceptions result
    in a logging.exception. All the errors are propogated to the device collector or top
    level device and a formatted NotConnected error is outputted
    evalott100 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    00ce76f View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. Configuration menu
    Copy the full SHA
    7cba553 View commit details
    Browse the repository at this point in the history