Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added number_of_frames instead of iterations #581

Merged
merged 5 commits into from
Oct 3, 2024

Commits on Sep 27, 2024

  1. Configuration menu
    Copy the full SHA
    3a56af0 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Refactor StandardDetector kickoff method to track the number of compl…

    …etable frames
    
    This commit refactors the kickoff method in the StandardDetector class to track the number of frames that can be completed after kickoff. The frames_completed attribute has been replaced with the completable_frames attribute, which represents the number of frames that can be completed. Additionally, the frames_completed attribute has been removed from the complete method and replaced with the completable_frames attribute. This change ensures that the completable_frames attribute is reset to 0 once the target number of iterations is reached and the detector is disarmed.
    ZohebShaikh committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d3758e3 View commit details
    Browse the repository at this point in the history
  2. Refactor test_hardware_triggered_flyable to use number_of_triggers in…

    …stead of number_of_frames
    ZohebShaikh committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    855e356 View commit details
    Browse the repository at this point in the history
  3. Refactor test_hardware_triggered_flyable to use number_of_triggers an…

    …d invoke_extra_kickoff_before_complete
    ZohebShaikh committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    fe8d188 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Configuration menu
    Copy the full SHA
    0651a3e View commit details
    Browse the repository at this point in the history