initial commit #560
Closed
initial commit #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZohebShaikh
force-pushed
the
549-support-multi-run-in-standarddetectorprepare
branch
from
a4c2043
to
e54b389
Compare
Comment on lines
+68
to
+71
| #: The number of times the detector can go through a complete cycle of kickoff and | ||
| #: complete without needing to re-arm. This is important for detectors where the | ||
| #: process of arming is expensive in terms of time | ||
| iteration: int = 0 |
There was a problem hiding this comment.
iterations or max_iterations may be slightly clearer?
can go through or will?
There was a problem hiding this comment.
This field also appears to not be used yet?
| @@ -73,32 +77,36 @@ class DetectorControl(ABC): | |||
| arming and disarming a detector | |||
| """ | |||
|
|
|||
| _arm_status = AsyncStatus | |||
There was a problem hiding this comment.
Suggested change
| _arm_status = AsyncStatus | |
| _arm_status: AsyncStatus | None |
This does require that all subclasses of DetectorControl have this field, and that it is this type. As arm is abstract, and we're leaving implementation to the implementations I'd avoid having any required fields like this.
| Args: | ||
| num: Expected number of frames | ||
| TriggerInfo which contains |
There was a problem hiding this comment.
Update to the new prepare params
| @abstractmethod | ||
| async def arm(self): | ||
| """ | ||
| Arm the detector and save the status of arm in _arm_status |
There was a problem hiding this comment.
Suggested change
| Arm the detector and save the status of arm in _arm_status | |
| Arm the detector |
| assert self._trigger_info, "Trigger Info cannot be none after prepare" | ||
| assert ( | ||
| self._trigger_info.trigger == DetectorTrigger.internal | ||
| ), "It can only be triggered for internal trigger" |
There was a problem hiding this comment.
Suggested change
| ), "It can only be triggered for internal trigger" | |
| ), "Cannot internally trigger with {self._trigger_info.trigger}" |
| trigger=self._trigger_info.trigger, | ||
| exposure=self._trigger_info.livetime, | ||
| ) | ||
| if value.trigger != DetectorTrigger.internal: |
There was a problem hiding this comment.
Suggested change
| if value.trigger != DetectorTrigger.internal: | |
| if value.trigger is not DetectorTrigger.internal: |
Should use is for enums
|
closed as duplicate #568 |
ZohebShaikh
deleted the
549-support-multi-run-in-standarddetectorprepare
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.