Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure code base and ensure tests still pass #5

Merged
merged 10 commits into from
Sep 14, 2023
Merged

Conversation

rosesyrett
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@coretl coretl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much there, I'm more on the "multiple classes per file" side of the fence, but a quick poll of the office suggests I'm in the minority, so I think you are right with your file splitting decisions.

I would like to reduce the import namespace however, so the top level namespace should be:

  • core
  • epics.signal
  • epics.areadetector
  • panda
    and those namespaces should be populated with __init__.pys that only import from modules that start with _

@rosesyrett rosesyrett merged commit e4d16b7 into main Sep 14, 2023
14 checks passed
@rosesyrett rosesyrett deleted the restructure branch September 14, 2023 13:42
@rosesyrett rosesyrett mentioned this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants