AD HDF plugin should set directory creation value before path #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coretl
requested changes
Jul 29, 2024
| await asyncio.gather( | ||
| self.hdf.num_extra_dims.set(0), | ||
| self.hdf.lazy_open.set(True), | ||
| self.hdf.swmr_mode.set(True), | ||
| self.hdf.create_dir_depth.set(info.create_dir_depth), |
There was a problem hiding this comment.
The gather will fire them off but there's no guarantee in the order they will be received. Better to await self.hdf.create_dir_depth before doing the await asyncio.gather of all the other signals
coretl
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the create_dir_depth record is not set first, then it will have no effect, since the callback to create the directories is done when the file path record is processed.