Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to root in PathInfo, PathProvider #477

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Remove references to root in PathInfo, PathProvider #477

merged 6 commits into from
Jul 23, 2024

Conversation

jwlodek
Copy link
Member

@jwlodek jwlodek commented Jul 23, 2024

Addresses #470

@jwlodek jwlodek requested review from mrakitin and coretl July 23, 2024 15:36
coretl
coretl reviewed Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@coretl coretl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question on naming, apart from that it looks good

src/ophyd_async/core/_providers.py Outdated Show resolved Hide resolved
@jwlodek jwlodek requested a review from coretl July 23, 2024 16:00
mrakitin
mrakitin approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mrakitin mrakitin merged commit 955414a into bluesky:main Jul 23, 2024
10 of 11 checks passed
@jwlodek jwlodek deleted the remove-root-path-provider branch August 9, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrakitin mrakitin mrakitin approved these changes

@coretl coretl coretl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwlodek @mrakitin @coretl