Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix motor run up distance #455

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Fix motor run up distance #455

merged 4 commits into from
Jul 17, 2024

Conversation

olliesilvester
Copy link
Contributor

@olliesilvester olliesilvester commented Jul 15, 2024 •
edited
Loading

I incorrectly calculated the run up distance in my last motor record PR

I should be doing run_up = acceleration_time * desired_speed/max_speed

What I had before was correct, I just forgot the factor of 1/2

@olliesilvester olliesilvester merged commit 8a9b9ac into bluesky:main Jul 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coretl coretl coretl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olliesilvester @coretl