-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made panda use pva signal backend instead of pvi_get #43
Conversation
Still need, but do not need to get the initial state, just get the pvi. |
eb19e25
to
1aea92c
Compare
@coretl: just checking that I am going in the right direction with this change? I've gotten to the point that the new code looks correct as far as I understand, but the pva fixture isn't playing nicely (timing out tests, not letting the test suite complete). It looks like |
Also: is there a standard for "FOO" + ":BAR" vs. "FOO:" + "BAR:" ? The latter seems to be more common in dodal, so I've been using it, assuming the trailing colon won't cause issue. I see in Rose's documentation change she also enforced that prefix should end with : if it isn't already |
DLS convention used to be no colon in the prefix, then colon added in the database. This only work because DLS PVs look like |
b5f7a10
to
76c4cd5
Compare
5003241
to
348438f
Compare
5653d9e
to
5ab25c0
Compare
48c1f8b
to
05a4d85
Compare
Test for getting the PVI info as a PVADict currently times out. I don't know enough about Epics DB Records to diagnose |
b3f1961
to
39b49e7
Compare
Removed the `_ensure_removed` and used a `tmp_path` instead. Each fixture uses its own `tmp_path`. Fixes some of the flakeyness in `tests/epics/test_signals.py::test_backend_get_put_monitor`.
Co-authored-by: Tom C (DLS) <[email protected]>
39b49e7
to
8c3852f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tom should Approve
c56f4da
to
289b3fe
Compare
289b3fe
to
fd3a1d8
Compare
Make use of PVASignalBackend standard Backend