Allow SoftSignals to have and propagate metadata #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiamondJoseph
force-pushed
the
356_signal_metadata
branch
2 times, most recently
from
097fb5a
to
d6399a0
Compare
coretl
approved these changes
Jun 5, 2024
|
when test is added... |
Merged
4 tasks
DiamondJoseph
commented
Jun 12, 2024
Comment on lines
152
to
153
| units: Optional[str] = None, | ||
| precision: Optional[int] = None, |
There was a problem hiding this comment.
Or SoftSignalBackend can take kwargs of other fields to pass as configuration.
e.g. units, precision, choices, limits
DiamondJoseph
force-pushed
the
356_signal_metadata
branch
2 times, most recently
from
5b5d767
to
110ffad
Compare
|
Replaced by #367 |
|
Wrong branch |
DiamondJoseph
force-pushed
the
356_signal_metadata
branch
from
110ffad
to
8401277
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #356