Add frame_timeout to trigger info #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumforrester
approved these changes
May 31, 2024
callumforrester
force-pushed
the
add-timeout-to-trigger-info
branch
from
7feb41a
to
c7b0449
Compare
|
This looks correct, thanks! |
abbiemery
force-pushed
the
add-timeout-to-trigger-info
branch
2 times, most recently
from
6087dd4
to
bcfd82e
Compare
callumforrester
approved these changes
Jun 4, 2024
abbiemery
force-pushed
the
add-timeout-to-trigger-info
branch
from
bcfd82e
to
33f9936
Compare
coretl
reviewed
Jun 4, 2024
Comment on lines
+245
to
+247
| self._trigger_info = TriggerInfo( | ||
| num=1, trigger=DetectorTrigger.internal, deadtime=0.0, livetime=0.0 | ||
| ) |
There was a problem hiding this comment.
What happens if you have previously run prepare(TriggerInfo(trigger=DetectorTrigger.internal, livetime=0.5)) as a way of setting up for a step scan with 0.5s exposure?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
frame_timeouttoTriggerInfoso that it can be passed in via prepare for flyscans. For stepscans a default set ofTriggerInfovalues are provided.I can't tell if this has made the tests longer or they already have got long.
Fixes #327 .