Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix p4p converter bug #276

Merged
merged 2 commits into from
May 2, 2024
Merged

Fix p4p converter bug #276

merged 2 commits into from
May 2, 2024

Conversation

evalott100
Copy link
Contributor

p4p will fail if it tries to use datatype int for a float value on a PV.

The panda currently has some fields which are analogue Out with precision 0, we should let these be ints in ophyd async even if the values come over as floats.

This should be adjusted to only allow this if .PREC is 0
@evalott100 evalott100 self-assigned this May 2, 2024
@evalott100 evalott100 marked this pull request as draft May 2, 2024 09:38
@evalott100 evalott100 marked this pull request as ready for review May 2, 2024 10:51
@evalott100
Copy link
Contributor Author

I made an issue for checking PREC: #280

Imo we should merge this to get panda working for the next sprint.

@evalott100 evalott100 requested a review from coretl May 2, 2024 10:59
Copy link
Collaborator

@coretl coretl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this is a quick fix until #280 is done

@evalott100 evalott100 merged commit b5df007 into main May 2, 2024
18 checks passed
@evalott100 evalott100 deleted the fix_prec_zero_float_failure branch May 2, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants