Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace-ad_rw #274

Merged
merged 7 commits into from
May 9, 2024
Merged

replace-ad_rw #274

merged 7 commits into from
May 9, 2024

Conversation

ZohebShaikh
Copy link
Contributor

closes #248

@ZohebShaikh
Copy link
Contributor Author

I think we can replace ad_r as well

def ad_r(datatype: Type[T], prefix: str) -> SignalR[T]:
    return epics_signal_r(datatype, prefix + "_RBV")

it just calls to epics_signal_r internally

@ZohebShaikh ZohebShaikh requested a review from abbiemery May 2, 2024 08:52
@coretl
Copy link
Collaborator

coretl commented May 2, 2024

I think we can replace ad_r as well

def ad_r(datatype: Type[T], prefix: str) -> SignalR[T]:
    return epics_signal_r(datatype, prefix + "_RBV")

it just calls to epics_signal_r internally

Yes please

Copy link
Collaborator

@coretl coretl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please can you also replace ad_r and then delete the utils.py that contains it

@ZohebShaikh ZohebShaikh requested review from coretl and removed request for rosesyrett May 2, 2024 09:53
@ZohebShaikh ZohebShaikh force-pushed the replace-ad-rw branch 2 times, most recently from 25ac9fb to ba7bd00 Compare May 2, 2024 13:57
@ZohebShaikh ZohebShaikh requested a review from coretl May 9, 2024 10:01
@coretl coretl merged commit ce5d585 into main May 9, 2024
18 checks passed
@coretl coretl deleted the replace-ad-rw branch May 9, 2024 14:53
@coretl coretl mentioned this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace ad_rw with epics_signal_rw_rbv
2 participants