Add docstring for DeviceVector and document how to group devices #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callumforrester
force-pushed
the
document-device-vector
branch
from
b0e593b
to
da17fb5
Compare
coretl
reviewed
Apr 9, 2024
| @@ -43,6 +49,19 @@ def __init__(self, prefix: str, name="") -> None: | |||
| super().__init__(name=name) | |||
|
|
|||
|
|
|||
| class SensorGroup(StandardReadable): | |||
There was a problem hiding this comment.
Does the ioc subprocess command at the bottom of the file actually contain all these sensors? I'd like to keep this file and the tutorials in step so that you can always run up an IOC to test the example code...
There was a problem hiding this comment.
It does now, although I think we should document that process/make it easier. Maybe even add tests to prove that the IOC contains the demo objects. I'll make an issue or two.
callumforrester
force-pushed
the
document-device-vector
branch
3 times, most recently
from
238f37b
to
37a38a1
Compare
coretl
approved these changes
Apr 15, 2024
callumforrester
force-pushed
the
document-device-vector
branch
from
37a38a1
to
d86ada4
Compare
callumforrester
force-pushed
the
document-device-vector
branch
3 times, most recently
from
4dc7815
to
10137fd
Compare
Move initial how-to on assembling devices into its own page and add a section about using DeviceVector to make arbitrary-length groups. Add an example to the epics demo with tests.
callumforrester
force-pushed
the
document-device-vector
branch
from
1dcb0c1
to
f39e48f
Compare
gilesknap
pushed a commit
to gilesknap/ophyd-async
that referenced
this pull request
Apr 18, 2024
…esky#183) * Add docstring for DeviceVector * Document How to Group Devices Move initial how-to on assembling devices into its own page and add a section about using DeviceVector to make arbitrary-length groups. Add an example to the epics demo with tests. * Add sensor group to demo IOC * Test IOC starts * Add timeout to IOC test * Only mock with IOC test for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add docstring for DeviceVector and document How to Group Devices
Move initial how-to on assembling devices into its own page and add a section about using DeviceVector to make arbitrary-length groups. Add an example to the epics demo with tests.